Hello, I was wanting to contribute to the community and I found a couple references to a deprecated javascript substr() where it would be better to use slice(). I was going to open an issue, but it doesn’t really qualify as a “bug” or a “vulnerability.”
I was going to open this as an issue and volunteer to tackle the issue, but is there a process for these sorts of code improvements that aren’t bugs?
Hi.
Yes. Please ask here or on open.rocket.chat whether a fix is required before wasting time on trying to fix things and opening issues that will likely be closed.
I presume this is you
I will ask them team but generally this sort of thing will get picked up and fixed by the team in time.
Totally understand! Thanks for the reply!
Hey reetp, I was tasked with this (thanks for letting me contribute!) and submitted a PR with the fix. However, I am getting this message on the PR
I am guessing this means it needs to be review by the internal team? Am i guessing correctly?
Also I’m failing…
CI / deploy-preview (pull_request)
CI / 
Build Docker Images for Testing (alpine) (pull_request)
Then it would appear that the Docker test failing skips 12 tests after it fails. Do you have anywhere you’d recommend looking to find what it is causing the failure? I didn’t change anything besides substr and slice in /apps/meteor/app/autotranslate/server/googleTranslate.ts
No one needs permission… just do it, though it is always better to check that it is OK to work on it as often these things are taken up internally.
Yup it needs the team to look. At this point you just have to be patient. It can take weeks, if not months sometimes. Rocket is not a bleeding edge project…